diff options
| author | Qiushi Wu <wu000273@umn.edu> | 2020-06-14 06:01:11 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-10-29 11:58:02 +0300 |
| commit | 7db4c3dfee01f5e403c2b97fdeb60506017fd355 (patch) | |
| tree | de753333fbc1ef80cc5e4ec8c4da5d4d80988ede /drivers/media/platform/exynos4-is/mipi-csis.c | |
| parent | f36a80bc75127bd87d288cefbd445a6a6c50904e (diff) | |
| download | linux-7db4c3dfee01f5e403c2b97fdeb60506017fd355.tar.xz | |
media: exynos4-is: Fix a reference count leak
[ Upstream commit 64157b2cb1940449e7df2670e85781c690266588 ]
pm_runtime_get_sync() increments the runtime PM usage counter even
when it returns an error code, causing incorrect ref count if
pm_runtime_put_noidle() is not called in error handling paths.
Thus call pm_runtime_put_noidle() if pm_runtime_get_sync() fails.
Signed-off-by: Qiushi Wu <wu000273@umn.edu>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/media/platform/exynos4-is/mipi-csis.c')
| -rw-r--r-- | drivers/media/platform/exynos4-is/mipi-csis.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/media/platform/exynos4-is/mipi-csis.c b/drivers/media/platform/exynos4-is/mipi-csis.c index 540151bbf58f..1aac167abb17 100644 --- a/drivers/media/platform/exynos4-is/mipi-csis.c +++ b/drivers/media/platform/exynos4-is/mipi-csis.c @@ -510,8 +510,10 @@ static int s5pcsis_s_stream(struct v4l2_subdev *sd, int enable) if (enable) { s5pcsis_clear_counters(state); ret = pm_runtime_get_sync(&state->pdev->dev); - if (ret && ret != 1) + if (ret && ret != 1) { + pm_runtime_put_noidle(&state->pdev->dev); return ret; + } } mutex_lock(&state->lock); |