diff options
| author | Markus Elfring <elfring@users.sourceforge.net> | 2016-10-07 23:07:27 +0300 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@s-opensource.com> | 2016-11-16 17:17:20 +0300 |
| commit | 045d69ce2116f72d9e658ff59427a11c93754a98 (patch) | |
| tree | 1132d71aa5396a23501d9345e972c4681b5b0b35 /drivers/media/pci/cx88/cx88-dsp.c | |
| parent | 68226b4dfa9b2e064e2f9e792bf7469f465054c7 (diff) | |
| download | linux-045d69ce2116f72d9e658ff59427a11c93754a98.tar.xz | |
[media] cx88-dsp: Use kmalloc_array() in read_rds_samples()
* A multiplication for the size determination of a memory allocation
indicated that an array data structure should be processed.
Thus use the corresponding function "kmalloc_array".
This issue was detected by using the Coccinelle software.
* Replace the specification of a data type by a pointer dereference
to make the corresponding size determination a bit safer according to
the Linux coding style convention.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Diffstat (limited to 'drivers/media/pci/cx88/cx88-dsp.c')
| -rw-r--r-- | drivers/media/pci/cx88/cx88-dsp.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/media/pci/cx88/cx88-dsp.c b/drivers/media/pci/cx88/cx88-dsp.c index 7fafd132ccaf..341e24432fab 100644 --- a/drivers/media/pci/cx88/cx88-dsp.c +++ b/drivers/media/pci/cx88/cx88-dsp.c @@ -245,8 +245,7 @@ static s16 *read_rds_samples(struct cx88_core *core, u32 *N) current_address, current_address - srch->fifo_start, sample_count, cx_read(MO_AUD_INTSTAT)); - - samples = kmalloc(sizeof(s16)*sample_count, GFP_KERNEL); + samples = kmalloc_array(sample_count, sizeof(*samples), GFP_KERNEL); if (!samples) return NULL; |