summaryrefslogtreecommitdiff
path: root/drivers/media/i2c/lm3646.c
diff options
context:
space:
mode:
authorColin Ian King <colin.king@canonical.com>2019-10-11 20:13:54 +0300
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>2019-10-25 00:41:31 +0300
commitecfaec43e4999cb584135fccc09760be775b735c (patch)
tree334f0af3666b04d47592face0d038e70c94dbfcb /drivers/media/i2c/lm3646.c
parentfdd5b6e3eff25b5ca9893dc0895589ae49b71008 (diff)
downloadlinux-ecfaec43e4999cb584135fccc09760be775b735c.tar.xz
media: lm3646: remove redundant assignment to variable rval
The variable rval is being initialized with a value that is never read and is being re-assigned a little later on. The assignment is redundant and hence can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Diffstat (limited to 'drivers/media/i2c/lm3646.c')
-rw-r--r--drivers/media/i2c/lm3646.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/media/i2c/lm3646.c b/drivers/media/i2c/lm3646.c
index d8a8853f9a2b..c76ccf67a909 100644
--- a/drivers/media/i2c/lm3646.c
+++ b/drivers/media/i2c/lm3646.c
@@ -134,7 +134,7 @@ static int lm3646_set_ctrl(struct v4l2_ctrl *ctrl)
{
struct lm3646_flash *flash = to_lm3646_flash(ctrl);
unsigned int reg_val;
- int rval = -EINVAL;
+ int rval;
switch (ctrl->id) {
case V4L2_CID_FLASH_LED_MODE: