diff options
| author | Demi Marie Obenour <demi@invisiblethingslab.com> | 2023-06-03 17:52:44 +0300 |
|---|---|---|
| committer | Mike Snitzer <snitzer@kernel.org> | 2023-06-23 17:31:52 +0300 |
| commit | 81ca2dbefaabe1a2ca1c7cfc84dfd45c072c82a6 (patch) | |
| tree | ea80c80e1d1ef1cb7375fcb64edbd9d41401d747 /drivers/md | |
| parent | a85f1a9de91a59cd9b12d60f631cbda9c56a1c3c (diff) | |
| download | linux-81ca2dbefaabe1a2ca1c7cfc84dfd45c072c82a6.tar.xz | |
dm ioctl: Refuse to create device named "." or ".."
Using either of these is going to greatly confuse userspace, as they are
not valid symlink names and so creating the usual /dev/mapper/NAME
symlink will not be possible. As creating a device with either of these
names is almost certainly a userspace bug, just error out.
Signed-off-by: Demi Marie Obenour <demi@invisiblethingslab.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>
Diffstat (limited to 'drivers/md')
| -rw-r--r-- | drivers/md/dm-ioctl.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/md/dm-ioctl.c b/drivers/md/dm-ioctl.c index e172a91e88dc..16244a7b193c 100644 --- a/drivers/md/dm-ioctl.c +++ b/drivers/md/dm-ioctl.c @@ -771,8 +771,10 @@ static int check_name(const char *name) return -EINVAL; } - if (strcmp(name, DM_CONTROL_NODE) == 0) { - DMERR("device name cannot be \"%s\"", DM_CONTROL_NODE); + if (strcmp(name, DM_CONTROL_NODE) == 0 || + strcmp(name, ".") == 0 || + strcmp(name, "..") == 0) { + DMERR("device name cannot be \"%s\", \".\", or \"..\"", DM_CONTROL_NODE); return -EINVAL; } |