diff options
| author | Yu Kuai <yukuai3@huawei.com> | 2023-08-25 06:09:52 +0300 |
|---|---|---|
| committer | Song Liu <song@kernel.org> | 2023-09-22 20:28:26 +0300 |
| commit | b721e7885eb242aa2459ee66bb42ceef1bcf0f0c (patch) | |
| tree | de2391398ad9305353f5fcbd6970877a9923e9b8 /drivers/md/md.c | |
| parent | b8494823e236326500aa1004155e83f748dd10da (diff) | |
| download | linux-b721e7885eb242aa2459ee66bb42ceef1bcf0f0c.tar.xz | |
md: don't rely on 'mddev->pers' to be set in mddev_suspend()
'active_io' used to be initialized while the array is running, and
'mddev->pers' is set while the array is running as well. Hence caller
must hold 'reconfig_mutex' and guarantee 'mddev->pers' is set before
calling mddev_suspend().
Now that 'active_io' is initialized when mddev is allocated, such
restriction doesn't exist anymore. In the meantime, follow up patches
will refactor mddev_suspend(), hence add checking for 'mddev->pers' to
prevent null-ptr-deref.
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Signed-off-by: Song Liu <song@kernel.org>
Link: https://lore.kernel.org/r/20230825030956.1527023-4-yukuai1@huaweicloud.com
Diffstat (limited to 'drivers/md/md.c')
| -rw-r--r-- | drivers/md/md.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/md/md.c b/drivers/md/md.c index 0212f504f36a..889c282a91ea 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -449,7 +449,7 @@ void mddev_suspend(struct mddev *mddev) set_bit(MD_ALLOW_SB_UPDATE, &mddev->flags); percpu_ref_kill(&mddev->active_io); - if (mddev->pers->prepare_suspend) + if (mddev->pers && mddev->pers->prepare_suspend) mddev->pers->prepare_suspend(mddev); wait_event(mddev->sb_wait, percpu_ref_is_zero(&mddev->active_io)); |