diff options
author | Lee Jones <lee.jones@linaro.org> | 2015-10-20 19:11:27 +0300 |
---|---|---|
committer | Jassi Brar <jaswinder.singh@linaro.org> | 2015-10-23 08:49:21 +0300 |
commit | a133f8b65d591101e48336050ceb7e2f51026502 (patch) | |
tree | 3189f4c3734e643f4ee30fc2bc7a3fdabbff968a /drivers/mailbox/omap-mailbox.c | |
parent | 6c03663f98b91cdd04fce2c9fb7a2cc5d164eded (diff) | |
download | linux-a133f8b65d591101e48336050ceb7e2f51026502.tar.xz |
mailbox: mailbox-test: Correctly repair Sparse warnings
Kbuild test robot reported some Sparse warnings to the tune of:
sparse: incorrect type in argument 6 (different address spaces)
expected void const *buf
got void [noderef] <asn:2>*mmio
This was due to passing variables tagged with the Sparse cookie
'__iomem' through into memcpy() and print_hex_dump() without
adequate protection or casting. These issues were fixed in a
previous patch suppressing the warnings, but the issue is indeed
still present.
This patch fixes the warnings in the correct way, i.e. by using
the purposely authored memcpy_{from,to}io() derivatives in the
memcpy() case and casting the memory address to (void *) and
forcing Sparse to ignore to ignore it in the print_hex_dump()
case [NB: This is also what the memcpy() derivatives do].
Reported-by: Peter Griffin <peter.griffin@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
Diffstat (limited to 'drivers/mailbox/omap-mailbox.c')
0 files changed, 0 insertions, 0 deletions