diff options
author | Arnaldo Carvalho de Melo <acme@redhat.com> | 2010-07-27 00:13:40 +0400 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2010-07-27 18:24:31 +0400 |
commit | 0f0cbf7aa3d3460a3eb201a772326739a0c0210a (patch) | |
tree | 9e2f4186acfd62a1a813abe576ffe6a35df9120d /drivers/macintosh/windfarm_pid.c | |
parent | 8d8c369f3d697e31e04133ca18b516952549ee33 (diff) | |
download | linux-0f0cbf7aa3d3460a3eb201a772326739a0c0210a.tar.xz |
perf ui: New hists tree widget
The stock newt checkbox tree widget we were using was not really
suitable for hist entry + callchain browsing.
The problems with it were manifold:
- We needed to traverse the whole hist_entry rb_tree to add each entry +
callchains beforehand.
- No control over the colors used for each row
So a new tree widget, based mostly on slang, was written.
It extends the ui_browser class already used for annotate to allow the
user to fold/unfold branches in the callchains tree, using extra fields
in the symbol_map class that is embedded in hist_entry and
callchain_node instances to store the folding state and when changing
this state calculates the number of rows that are produced when showing
a particular hist_entry instance.
This greatly speeds up browsing as we don't have to upfront touch all
the entries and only calculate callchain related operations when some
callchain branch is actually unfolded.
The memory footprint is also reduced as the data structure is not
duplicated, just some extra fields for controling callchain state and to
simplify the process of seeking thru entries (nr_rows, row_offset) were
added.
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
LKML-Reference: <new-submission>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'drivers/macintosh/windfarm_pid.c')
0 files changed, 0 insertions, 0 deletions