diff options
| author | Jean Delvare <khali@linux-fr.org> | 2009-10-05 00:53:46 +0400 |
|---|---|---|
| committer | Jean Delvare <khali@linux-fr.org> | 2009-10-05 00:53:46 +0400 |
| commit | 6f6b35e133fe4313277b30fc1a7ea313875ea6c9 (patch) | |
| tree | 1b7aa0dde7d69b0f90b80a0398c9699faae6260e /drivers/macintosh/windfarm_max6690_sensor.c | |
| parent | 18669eabde2ff5fc446e72e043f0539059763438 (diff) | |
| download | linux-6f6b35e133fe4313277b30fc1a7ea313875ea6c9.tar.xz | |
macintosh: Don't assume i2c device probing always succeeds
If i2c device probing fails, then there is no driver to dereference
after calling i2c_new_device(). Stop assuming that probing will always
succeed, to avoid NULL pointer dereferences. We have an easier access
to the driver anyway.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Tested-by: Tim Shepard <shep@alum.mit.edu>
Cc: Colin Leroy <colin@colino.net>
Diffstat (limited to 'drivers/macintosh/windfarm_max6690_sensor.c')
| -rw-r--r-- | drivers/macintosh/windfarm_max6690_sensor.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/macintosh/windfarm_max6690_sensor.c b/drivers/macintosh/windfarm_max6690_sensor.c index e2a55ecda2b2..a67b349319e9 100644 --- a/drivers/macintosh/windfarm_max6690_sensor.c +++ b/drivers/macintosh/windfarm_max6690_sensor.c @@ -88,6 +88,8 @@ static int wf_max6690_probe(struct i2c_client *client, return rc; } +static struct i2c_driver wf_max6690_driver; + static struct i2c_client *wf_max6690_create(struct i2c_adapter *adapter, u8 addr, const char *loc) { @@ -119,7 +121,7 @@ static struct i2c_client *wf_max6690_create(struct i2c_adapter *adapter, * Let i2c-core delete that device on driver removal. * This is safe because i2c-core holds the core_lock mutex for us. */ - list_add_tail(&client->detected, &client->driver->clients); + list_add_tail(&client->detected, &wf_max6690_driver.clients); return client; fail: |