summaryrefslogtreecommitdiff
path: root/drivers/macintosh/adbhid.c
diff options
context:
space:
mode:
authorDan Carpenter <error27@gmail.com>2022-12-07 10:06:31 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2022-12-14 13:37:30 +0300
commit40500f1f47450fa68852ea7dde93284f81568487 (patch)
tree468f4b34e651bc30f10296acbd4a71d11042c914 /drivers/macintosh/adbhid.c
parentb9274dbe399952a8175db2e1ee148b7c9ba2b538 (diff)
downloadlinux-40500f1f47450fa68852ea7dde93284f81568487.tar.xz
net: mvneta: Fix an out of bounds check
[ Upstream commit cdd97383e19d4afe29adc3376025a15ae3bab3a3 ] In an earlier commit, I added a bounds check to prevent an out of bounds read and a WARN(). On further discussion and consideration that check was probably too aggressive. Instead of returning -EINVAL, a better fix would be to just prevent the out of bounds read but continue the process. Background: The value of "pp->rxq_def" is a number between 0-7 by default, or even higher depending on the value of "rxq_number", which is a module parameter. If the value is more than the number of available CPUs then it will trigger the WARN() in cpu_max_bits_warn(). Fixes: e8b4fc13900b ("net: mvneta: Prevent out of bounds read in mvneta_config_rss()") Signed-off-by: Dan Carpenter <error27@gmail.com> Reviewed-by: Leon Romanovsky <leonro@nvidia.com> Link: https://lore.kernel.org/r/Y5A7d1E5ccwHTYPf@kadam Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/macintosh/adbhid.c')
0 files changed, 0 insertions, 0 deletions