diff options
author | Kars de Jong <jongk@linux-m68k.org> | 2019-11-16 14:46:20 +0300 |
---|---|---|
committer | Alexandre Belloni <alexandre.belloni@bootlin.com> | 2019-11-18 17:23:54 +0300 |
commit | 32c4d9e8a4eb286674dc1a3b93d51d791c7f645e (patch) | |
tree | 50570b50f40b17d5669058401b70bce0a5bc36c4 /drivers/irqchip/irq-sni-exiu.c | |
parent | e34494c8df0cd96fc432efae121db3212c46ae48 (diff) | |
download | linux-32c4d9e8a4eb286674dc1a3b93d51d791c7f645e.tar.xz |
rtc: msm6242: Remove unneeded msm6242_set()/msm6242_clear() functions
The msm6242_set()/msm6242_clear() functions are used when writing to Control
Register D to set or clear the HOLD bit when reading the current time from
the RTC.
Doing this with a read-modify-write cycle will potentially clear an
interrupt condition which occurs between the read and the write.
The datasheet states the following about this:
When writing the HOLD or 30 second adjust bits of register D, it is
necessary to write the IRQ FLAG bit to a "1".
Since the only other bits in the register are the 30 second adjust bit
(which is not used) and the BUSY bit (which is read-only), the
read-modify-write cycle can be replaced by a simple write with the IRQ FLAG
bit set to 1 and the other bits (except HOLD) set to 0.
Tested-by: Kars de Jong <jongk@linux-m68k.org>
Signed-off-by: Kars de Jong <jongk@linux-m68k.org>
Link: https://lore.kernel.org/r/20191116114620.9193-1-jongk@linux-m68k.org
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Diffstat (limited to 'drivers/irqchip/irq-sni-exiu.c')
0 files changed, 0 insertions, 0 deletions