diff options
author | Will Deacon <will.deacon@arm.com> | 2018-11-08 01:58:24 +0300 |
---|---|---|
committer | Will Deacon <will.deacon@arm.com> | 2018-12-10 17:55:58 +0300 |
commit | a868e8530441286342f90c1fd9c5f24de3aa2880 (patch) | |
tree | e7cdacc6b471fb766357a0a842b8f5dd1bcba33e /drivers/iommu/arm-smmu.c | |
parent | 84a9a75774961612d0c7dd34a1777e8f98a65abd (diff) | |
download | linux-a868e8530441286342f90c1fd9c5f24de3aa2880.tar.xz |
iommu/arm-smmu-v3: Use explicit mb() when moving cons pointer
After removing an entry from a queue (e.g. reading an event in
arm_smmu_evtq_thread()) it is necessary to advance the MMIO consumer
pointer to free the queue slot back to the SMMU. A memory barrier is
required here so that all reads targetting the queue entry have
completed before the consumer pointer is updated.
The implementation of queue_inc_cons() relies on a writel() to complete
the previous reads, but this is incorrect because writel() is only
guaranteed to complete prior writes. This patch replaces the call to
writel() with an mb(); writel_relaxed() sequence, which gives us the
read->write ordering which we require.
Cc: Robin Murphy <robin.murphy@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
Diffstat (limited to 'drivers/iommu/arm-smmu.c')
0 files changed, 0 insertions, 0 deletions