diff options
| author | Hangbin Liu <liuhangbin@gmail.com> | 2014-01-03 07:33:45 +0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2014-01-04 05:38:56 +0400 |
| commit | 0d68fc4f1210f8caea2bdd68f99dc6da35ee3740 (patch) | |
| tree | f43d45c068c5f990a73748b71feefa62f6010f3f /drivers/infiniband/ulp/ipoib/ipoib_netlink.c | |
| parent | 7bda701e012373ca53c9d837b7b25131852e0238 (diff) | |
| download | linux-0d68fc4f1210f8caea2bdd68f99dc6da35ee3740.tar.xz | |
infiniband: make sure the src net is infiniband when create new link
When we create a new infiniband link with uninfiniband device, e.g. `ip link
add link em1 type ipoib pkey 0x8001`. We will get a NULL pointer dereference
cause other dev like Ethernet don't have struct ib_device.
The code path is:
rtnl_newlink
|-- ipoib_new_child_link
|-- __ipoib_vlan_add
|-- ipoib_set_dev_features
|-- ib_query_device
Fix this bug by make sure the src net is infiniband when create new link.
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/infiniband/ulp/ipoib/ipoib_netlink.c')
| -rw-r--r-- | drivers/infiniband/ulp/ipoib/ipoib_netlink.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/infiniband/ulp/ipoib/ipoib_netlink.c b/drivers/infiniband/ulp/ipoib/ipoib_netlink.c index c29b5c838833..cdc7df4fdb8a 100644 --- a/drivers/infiniband/ulp/ipoib/ipoib_netlink.c +++ b/drivers/infiniband/ulp/ipoib/ipoib_netlink.c @@ -31,6 +31,7 @@ */ #include <linux/netdevice.h> +#include <linux/if_arp.h> /* For ARPHRD_xxx */ #include <linux/module.h> #include <net/rtnetlink.h> #include "ipoib.h" @@ -103,7 +104,7 @@ static int ipoib_new_child_link(struct net *src_net, struct net_device *dev, return -EINVAL; pdev = __dev_get_by_index(src_net, nla_get_u32(tb[IFLA_LINK])); - if (!pdev) + if (!pdev || pdev->type != ARPHRD_INFINIBAND) return -ENODEV; ppriv = netdev_priv(pdev); |