diff options
| author | Faisal Latif <faisal.latif@intel.com> | 2009-04-09 01:22:20 +0400 |
|---|---|---|
| committer | Roland Dreier <rolandd@cisco.com> | 2009-04-09 01:22:20 +0400 |
| commit | 79fc3d7410c861c8ced5b81a5c3759f6bbf891dc (patch) | |
| tree | 99c16570cd52c43d65bc9ca4e60f3c4e34d4ae7e /drivers/infiniband/hw/nes/nes_cm.h | |
| parent | 7a5efb62f6ae366cefac6be475434906c5061e15 (diff) | |
| download | linux-79fc3d7410c861c8ced5b81a5c3759f6bbf891dc.tar.xz | |
RDMA/nes: Fix error handling issues
Fix issues found by static code analysis:
(1) Check if cm_node was successfully created for loopback connection.
(2) schedule_nes_timer() does not free up allocated memory after
encountering an error. There is a WARN_ON() for this condition.
(3) there is a cm_node->freed flag which is set but not used.
Reported-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Faisal Latif <faisal.latif@intel.com>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
Diffstat (limited to 'drivers/infiniband/hw/nes/nes_cm.h')
| -rw-r--r-- | drivers/infiniband/hw/nes/nes_cm.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/infiniband/hw/nes/nes_cm.h b/drivers/infiniband/hw/nes/nes_cm.h index d5f778202eb7..80bba1892571 100644 --- a/drivers/infiniband/hw/nes/nes_cm.h +++ b/drivers/infiniband/hw/nes/nes_cm.h @@ -298,7 +298,6 @@ struct nes_cm_node { struct nes_vnic *nesvnic; int apbvt_set; int accept_pend; - int freed; struct list_head timer_entry; struct list_head reset_entry; struct nes_qp *nesqp; |