diff options
| author | Jarkko Nikula <jarkko.nikula@linux.intel.com> | 2021-10-26 17:39:16 +0300 |
|---|---|---|
| committer | Wolfram Sang <wsa@kernel.org> | 2021-10-29 22:30:26 +0300 |
| commit | 1ad5dc3540d8c621d1e15a6bff9c0ac30fba2857 (patch) | |
| tree | c1bd732075ac58a639e19a990665a3af69c59c4c /drivers/i2c/busses/i2c-i801.c | |
| parent | cc28e578f515f068cd8ee280706b8d8e31c472f9 (diff) | |
| download | linux-1ad5dc3540d8c621d1e15a6bff9c0ac30fba2857.tar.xz | |
i2c: i801: Fix incorrect and needless software PEC disabling
Commit a6b8bb6a813a ("i2c: i801: Fix handling SMBHSTCNT_PEC_EN")
attempts to disable software PEC by clearing the SMBHSTCNT_PEC_EN (bit 7)
in the SMBus Host Control register (I/O SMBHSTCNT) but incorrectly
clears it in the PCI Host Configuration register (PCI SMBHSTCFG).
This clearing is actually needless since after above commit the
SMBHSTCNT_PEC_EN is never set and the register is initialized with known
values.
Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Acked-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
Diffstat (limited to 'drivers/i2c/busses/i2c-i801.c')
| -rw-r--r-- | drivers/i2c/busses/i2c-i801.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c index 115660dce722..b6048a571543 100644 --- a/drivers/i2c/busses/i2c-i801.c +++ b/drivers/i2c/busses/i2c-i801.c @@ -1657,7 +1657,6 @@ static void i801_setup_hstcfg(struct i801_priv *priv) unsigned char hstcfg = priv->original_hstcfg; hstcfg &= ~SMBHSTCFG_I2C_EN; /* SMBus timing */ - hstcfg &= ~SMBHSTCNT_PEC_EN; /* Disable software PEC */ hstcfg |= SMBHSTCFG_HST_EN; pci_write_config_byte(priv->pci_dev, SMBHSTCFG, hstcfg); } |