diff options
author | Bryant G. Ly <bryantly@linux.vnet.ibm.com> | 2017-05-10 22:35:47 +0300 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-06-07 13:07:47 +0300 |
commit | 69b1d90e6a0f848e84d49b5771acbfe97ec30150 (patch) | |
tree | bb0238be28dfcfa8f2def0a50ff10a99b95b6fef /drivers/hid | |
parent | 80569d0e09add209e80c1354af8433daac506f35 (diff) | |
download | linux-69b1d90e6a0f848e84d49b5771acbfe97ec30150.tar.xz |
ibmvscsis: Fix the incorrect req_lim_delta
commit 75dbf2d36f6b122ad3c1070fe4bf95f71bbff321 upstream.
The current code is not correctly calculating the req_lim_delta.
We want to make sure vscsi->credit is always incremented when
we do not send a response for the scsi op. Thus for the case where
there is a successfully aborted task we need to make sure the
vscsi->credit is incremented.
v2 - Moves the original location of the vscsi->credit increment
to a better spot. Since if we increment credit, the next command
we send back will have increased req_lim_delta. But we probably
shouldn't be doing that until the aborted cmd is actually released.
Otherwise the client will think that it can send a new command, and
we could find ourselves short of command elements. Not likely, but could
happen.
This patch depends on both:
commit 25e78531268e ("ibmvscsis: Do not send aborted task response")
commit 98883f1b5415 ("ibmvscsis: Clear left-over abort_cmd pointers")
Signed-off-by: Bryant G. Ly <bryantly@linux.vnet.ibm.com>
Reviewed-by: Michael Cyr <mikecyr@linux.vnet.ibm.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/hid')
0 files changed, 0 insertions, 0 deletions