diff options
| author | Zhen Lei <thunder.leizhen@huawei.com> | 2021-05-08 05:47:37 +0300 |
|---|---|---|
| committer | Jiri Kosina <jkosina@suse.cz> | 2021-05-27 16:40:34 +0300 |
| commit | 3dd653c077efda8152f4dd395359617d577a54cd (patch) | |
| tree | e7f28b353318fdd9894c748ea6e062058478ef29 /drivers/hid/usbhid/hid-pidff.c | |
| parent | 81c8bf9170477d453b24a6bc3300d201d641e645 (diff) | |
| download | linux-3dd653c077efda8152f4dd395359617d577a54cd.tar.xz | |
HID: pidff: fix error return code in hid_pidff_init()
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.
Fixes: 224ee88fe395 ("Input: add force feedback driver for PID devices")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/hid/usbhid/hid-pidff.c')
| -rw-r--r-- | drivers/hid/usbhid/hid-pidff.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid/usbhid/hid-pidff.c index ea126c50acc3..3b4ee21cd811 100644 --- a/drivers/hid/usbhid/hid-pidff.c +++ b/drivers/hid/usbhid/hid-pidff.c @@ -1292,6 +1292,7 @@ int hid_pidff_init(struct hid_device *hid) if (pidff->pool[PID_DEVICE_MANAGED_POOL].value && pidff->pool[PID_DEVICE_MANAGED_POOL].value[0] == 0) { + error = -EPERM; hid_notice(hid, "device does not support device managed pool\n"); goto fail; |