diff options
author | Martin Kelly <martin@martingkelly.com> | 2018-10-29 06:18:53 +0300 |
---|---|---|
committer | Jonathan Cameron <Jonathan.Cameron@huawei.com> | 2018-11-03 14:24:07 +0300 |
commit | fe5192ac81ad0d4dfe1395d11f393f0513c15f7f (patch) | |
tree | 0efada9147c34a55e58b568490f6a5e1e8f9a169 /drivers/hid/hid-sensor-hub.c | |
parent | 310c7585e8300ddc46211df0757c11e4299ec482 (diff) | |
download | linux-fe5192ac81ad0d4dfe1395d11f393f0513c15f7f.tar.xz |
iio:st_magn: Fix enable device after trigger
Currently, we enable the device before we enable the device trigger. At
high frequencies, this can cause interrupts that don't yet have a poll
function associated with them and are thus treated as spurious. At high
frequencies with level interrupts, this can even cause an interrupt storm
of repeated spurious interrupts (~100,000 on my Beagleboard with the
LSM9DS1 magnetometer). If these repeat too much, the interrupt will get
disabled and the device will stop functioning.
To prevent these problems, enable the device prior to enabling the device
trigger, and disable the divec prior to disabling the trigger. This means
there's no window of time during which the device creates interrupts but we
have no trigger to answer them.
Fixes: 90efe055629 ("iio: st_sensors: harden interrupt handling")
Signed-off-by: Martin Kelly <martin@martingkelly.com>
Tested-by: Denis Ciocca <denis.ciocca@st.com>
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Diffstat (limited to 'drivers/hid/hid-sensor-hub.c')
0 files changed, 0 insertions, 0 deletions