summaryrefslogtreecommitdiff
path: root/drivers/gpu/drm/xe/xe_rtp_types.h
diff options
context:
space:
mode:
authorLucas De Marchi <lucas.demarchi@intel.com>2023-01-26 02:03:07 +0300
committerRodrigo Vivi <rodrigo.vivi@intel.com>2023-12-20 02:28:12 +0300
commit3747c88428a199620ca626a196781516c6da12e6 (patch)
tree6d39a527123c3fc5463d0dbcdb35f45308cc1adf /drivers/gpu/drm/xe/xe_rtp_types.h
parent564d64f83de9759c1faa4a64ee4aed8465281ecb (diff)
downloadlinux-3747c88428a199620ca626a196781516c6da12e6.tar.xz
drm/xe: Rename xe_rtp_regval to xe_rtp_action
It's true that the struct records the register and the value (in form of 2 masks) to restore, but it also records more fields important to the application of workarounds/tuning, etc. One important part is what is the macro used to record these fields: SET/CLR/WR/FIELD_SET/etc. Thinking of the table as a set of rules + actions is more intuitive than rules + regval. Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Diffstat (limited to 'drivers/gpu/drm/xe/xe_rtp_types.h')
-rw-r--r--drivers/gpu/drm/xe/xe_rtp_types.h9
1 files changed, 6 insertions, 3 deletions
diff --git a/drivers/gpu/drm/xe/xe_rtp_types.h b/drivers/gpu/drm/xe/xe_rtp_types.h
index 630a2ec53fc6..9cd722f310cb 100644
--- a/drivers/gpu/drm/xe/xe_rtp_types.h
+++ b/drivers/gpu/drm/xe/xe_rtp_types.h
@@ -19,9 +19,12 @@ enum {
};
/**
- * struct xe_rtp_regval - register and value for rtp table
+ * struct xe_rtp_action - action to take for any matching rule
+ *
+ * This struct records what action should be taken in a register that has a
+ * matching rule. Example of actions: set/clear bits.
*/
-struct xe_rtp_regval {
+struct xe_rtp_action {
/** @reg: Register */
u32 reg;
/** @clr_bits: bits to clear when updating register */
@@ -93,7 +96,7 @@ struct xe_rtp_rule {
/** struct xe_rtp_entry - Entry in an rtp table */
struct xe_rtp_entry {
const char *name;
- const struct xe_rtp_regval regval;
+ const struct xe_rtp_action action;
const struct xe_rtp_rule *rules;
unsigned int n_rules;
};