diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2021-11-18 14:12:33 +0300 |
|---|---|---|
| committer | Hans de Goede <hdegoede@redhat.com> | 2021-11-18 15:27:14 +0300 |
| commit | cebbb5c46d0cb0615fd0c62dea9b44273d0a9780 (patch) | |
| tree | 63ccf94449ded0bde968f263f5ccc3e7fc671906 /drivers/gpu/drm/vboxvideo | |
| parent | bc30c3b0c8a1904d83d5f0d60fb8650a334b207b (diff) | |
| download | linux-cebbb5c46d0cb0615fd0c62dea9b44273d0a9780.tar.xz | |
drm/vboxvideo: fix a NULL vs IS_ERR() check
The devm_gen_pool_create() function never returns NULL, it returns
error pointers.
Fixes: 4cc9b565454b ("drm/vboxvideo: Use devm_gen_pool_create")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20211118111233.GA1147@kili
Diffstat (limited to 'drivers/gpu/drm/vboxvideo')
| -rw-r--r-- | drivers/gpu/drm/vboxvideo/vbox_main.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/gpu/drm/vboxvideo/vbox_main.c b/drivers/gpu/drm/vboxvideo/vbox_main.c index f28779715ccd..c9e8b3a63c62 100644 --- a/drivers/gpu/drm/vboxvideo/vbox_main.c +++ b/drivers/gpu/drm/vboxvideo/vbox_main.c @@ -127,8 +127,8 @@ int vbox_hw_init(struct vbox_private *vbox) /* Create guest-heap mem-pool use 2^4 = 16 byte chunks */ vbox->guest_pool = devm_gen_pool_create(vbox->ddev.dev, 4, -1, "vboxvideo-accel"); - if (!vbox->guest_pool) - return -ENOMEM; + if (IS_ERR(vbox->guest_pool)) + return PTR_ERR(vbox->guest_pool); ret = gen_pool_add_virt(vbox->guest_pool, (unsigned long)vbox->guest_heap, |