diff options
| author | Rasmus Villemoes <linux@rasmusvillemoes.dk> | 2016-02-09 23:11:13 +0300 |
|---|---|---|
| committer | Jani Nikula <jani.nikula@intel.com> | 2016-02-10 11:53:29 +0300 |
| commit | 2417c8c03f508841b85bf61acc91836b7b0e2560 (patch) | |
| tree | f82e45689ab3edbd95e81b20be300dd397fb9efd /drivers/gpu/drm/i915/intel_i2c.c | |
| parent | 3e99a6b9561402909fdb3b0028764d42557e0103 (diff) | |
| download | linux-2417c8c03f508841b85bf61acc91836b7b0e2560.tar.xz | |
drm/i915: fix error path in intel_setup_gmbus()
This fails to undo the setup for pin==0; moreover, something
interesting happens if the setup failed already at pin==0.
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Fixes: f899fc64cda8 ("drm/i915: use GMBUS to manage i2c links")
Cc: stable@vger.kernel.org
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1455048677-19882-3-git-send-email-linux@rasmusvillemoes.dk
Diffstat (limited to 'drivers/gpu/drm/i915/intel_i2c.c')
| -rw-r--r-- | drivers/gpu/drm/i915/intel_i2c.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/i915/intel_i2c.c b/drivers/gpu/drm/i915/intel_i2c.c index 25254b5c1ac5..deb8282c26d8 100644 --- a/drivers/gpu/drm/i915/intel_i2c.c +++ b/drivers/gpu/drm/i915/intel_i2c.c @@ -683,7 +683,7 @@ int intel_setup_gmbus(struct drm_device *dev) return 0; err: - while (--pin) { + while (pin--) { if (!intel_gmbus_is_valid_pin(dev_priv, pin)) continue; |