diff options
| author | Chris Wilson <chris@chris-wilson.co.uk> | 2017-05-17 15:09:56 +0300 |
|---|---|---|
| committer | Chris Wilson <chris@chris-wilson.co.uk> | 2017-05-17 15:38:01 +0300 |
| commit | 9310cb7f8dbee342995c1144714218a185e7dd07 (patch) | |
| tree | f7007fc5916300cb672579e4d434ff1e16dcd3e8 /drivers/gpu/drm/i915/i915_sw_fence.h | |
| parent | 0b71cea29fc29bbd8e9dd9c641fee6bd75f68274 (diff) | |
| download | linux-9310cb7f8dbee342995c1144714218a185e7dd07.tar.xz | |
drm/i915: Remove kref from i915_sw_fence
My original intention was for i915_sw_fence to be the base class and
provide the reference count for the container. This was from starting
with a design to handle async_work. In practice, for i915 we embed
fences into structs which have their own independent reference counting,
making the i915_sw_fence.kref duplicitous. If we remove the kref, we
remove the i915_sw_fence's ability to free itself and its independence,
it can only exist within a container and must be supplied with a
callback to handle its release.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Mika Kuoppala <mika.kuoppala@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20170517121007.27224-1-chris@chris-wilson.co.uk
Diffstat (limited to 'drivers/gpu/drm/i915/i915_sw_fence.h')
| -rw-r--r-- | drivers/gpu/drm/i915/i915_sw_fence.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/gpu/drm/i915/i915_sw_fence.h b/drivers/gpu/drm/i915/i915_sw_fence.h index d31cefbbcc04..1d3b6051daaf 100644 --- a/drivers/gpu/drm/i915/i915_sw_fence.h +++ b/drivers/gpu/drm/i915/i915_sw_fence.h @@ -23,7 +23,6 @@ struct reservation_object; struct i915_sw_fence { wait_queue_head_t wait; unsigned long flags; - struct kref kref; atomic_t pending; }; |