diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2017-01-20 19:54:32 +0300 |
|---|---|---|
| committer | Inki Dae <inki.dae@samsung.com> | 2017-01-31 02:50:30 +0300 |
| commit | 8646dcb8a0def1c1cd4c855e08b17abce0cdc5d1 (patch) | |
| tree | 01efae5faec3ce8103da8a5e5907d71912331a62 /drivers/gpu/drm/exynos | |
| parent | 41cbf0fdaa2886241f92f014ae1fd12bd5689af4 (diff) | |
| download | linux-8646dcb8a0def1c1cd4c855e08b17abce0cdc5d1.tar.xz | |
drm/exynos: fix a timeout loop
We were trying to print an error message if we timed out here, but the
loop actually ends with "tries" set to UINT_MAX and not zero. Fix this
by changing from tries-- to --tries.
A for loop would actually be the most natural way to do this. My fix
means we only loop 99 times instead of 100 but that's probably ok.
Fixes: a696394c5224 ('drm/exynos: mixer: simplify loop in vp_win_reset()')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
Signed-off-by: Inki Dae <inki.dae@samsung.com>
Diffstat (limited to 'drivers/gpu/drm/exynos')
| -rw-r--r-- | drivers/gpu/drm/exynos/exynos_mixer.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos/exynos_mixer.c index a106046e0c93..72143ac10525 100644 --- a/drivers/gpu/drm/exynos/exynos_mixer.c +++ b/drivers/gpu/drm/exynos/exynos_mixer.c @@ -701,7 +701,7 @@ static void vp_win_reset(struct mixer_context *ctx) unsigned int tries = 100; vp_reg_write(res, VP_SRESET, VP_SRESET_PROCESSING); - while (tries--) { + while (--tries) { /* waiting until VP_SRESET_PROCESSING is 0 */ if (~vp_reg_read(res, VP_SRESET) & VP_SRESET_PROCESSING) break; |