diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2022-06-15 15:47:18 +0300 |
|---|---|---|
| committer | Bartosz Golaszewski <brgl@bgdev.pl> | 2022-07-19 10:57:13 +0300 |
| commit | 3d57fa2a228c973032e94aceeef92a3e9704b9ea (patch) | |
| tree | b33b0e65ecd21ecde28b68fc8938b963e6da5f42 /drivers/gpio/gpio-xgs-iproc.c | |
| parent | 1923433cd660fda6315b8eb1bb8372cf7e85acf7 (diff) | |
| download | linux-3d57fa2a228c973032e94aceeef92a3e9704b9ea.tar.xz | |
gpio: xgs-iproc: Drop if with an always false condition
The remove callback is only called after probe completed successfully.
In this case platform_set_drvdata() was called with a non-NULL argument
and so chip is never NULL.
Also note that returning an error code from a remove callback doesn't
result in the device staying bound. It's still removed and devm
callbacks are called.
This is a preparation for making platform remove callbacks return void.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
Diffstat (limited to 'drivers/gpio/gpio-xgs-iproc.c')
| -rw-r--r-- | drivers/gpio/gpio-xgs-iproc.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/drivers/gpio/gpio-xgs-iproc.c b/drivers/gpio/gpio-xgs-iproc.c index 43ca52fa6f9a..fd88500399c6 100644 --- a/drivers/gpio/gpio-xgs-iproc.c +++ b/drivers/gpio/gpio-xgs-iproc.c @@ -281,11 +281,7 @@ static int iproc_gpio_probe(struct platform_device *pdev) static int iproc_gpio_remove(struct platform_device *pdev) { - struct iproc_gpio_chip *chip; - - chip = platform_get_drvdata(pdev); - if (!chip) - return -ENODEV; + struct iproc_gpio_chip *chip = platform_get_drvdata(pdev); if (chip->intr) { u32 val; |