diff options
author | Ben Hutchings <bhutchings@solarflare.com> | 2011-04-02 03:35:15 +0400 |
---|---|---|
committer | Ben Hutchings <bhutchings@solarflare.com> | 2011-04-05 18:12:01 +0400 |
commit | 68f512f21a64c9b264df6c61a9333e7890faf74b (patch) | |
tree | 4635193aaec903f09ae69df4dc880296d74c5135 /drivers/firewire | |
parent | 8717d07b1143e0f150921f5bd7cfe7af579a995a (diff) | |
download | linux-68f512f21a64c9b264df6c61a9333e7890faf74b.tar.xz |
ethtool: Change ETHTOOL_PHYS_ID implementation to allow dropping RTNL
The ethtool ETHTOOL_PHYS_ID command runs for an arbitrarily long
period of time, holding the RTNL lock. This blocks routing updates,
device enumeration, and various important operations that one might
want to keep running while hunting for the flashing LED.
We need to drop the RTNL lock during this operation, but currently the
core implementation is a thin wrapper around a driver operation and
drivers may well depend upon holding the lock.
Define a new driver operation 'set_phys_id' with an argument that sets
the ID indicator on/off/inactive/active (the last optional, for any
driver or firmware that prefers to handle blinking asynchronously).
When this is defined, the ethtool core drops the lock while waiting
and only acquires it around calls to this operation.
Deprecate the 'phys_id' operation in favour of this. It can be
removed once all in-tree drivers are converted.
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Diffstat (limited to 'drivers/firewire')
0 files changed, 0 insertions, 0 deletions