diff options
| author | Wei Yongjun <weiyongjun1@huawei.com> | 2019-01-25 04:45:54 +0300 |
|---|---|---|
| committer | Chanwoo Choi <cw00.choi@samsung.com> | 2019-02-11 11:21:38 +0300 |
| commit | 3dfed89512d3b65f6f092cfaaee53b0698bbf75e (patch) | |
| tree | 3ba87a1eca05c1f4be83b0a87603fdcc42680d3a /drivers/extcon/extcon-ptn5150.c | |
| parent | 4ed754de2d66084d4a7785f565d7c42ad89a3ea9 (diff) | |
| download | linux-3dfed89512d3b65f6f092cfaaee53b0698bbf75e.tar.xz | |
extcon: ptn5150: Fix return value check in ptn5150_i2c_probe()
In case of error, the function devm_gpiod_get() returns ERR_PTR() and
never returns NULL. The NULL test in the return value check should be
replaced with IS_ERR().
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
Diffstat (limited to 'drivers/extcon/extcon-ptn5150.c')
| -rw-r--r-- | drivers/extcon/extcon-ptn5150.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/extcon/extcon-ptn5150.c b/drivers/extcon/extcon-ptn5150.c index 18a8f258767b..d1c997599390 100644 --- a/drivers/extcon/extcon-ptn5150.c +++ b/drivers/extcon/extcon-ptn5150.c @@ -240,14 +240,14 @@ static int ptn5150_i2c_probe(struct i2c_client *i2c, info->dev = &i2c->dev; info->i2c = i2c; info->int_gpiod = devm_gpiod_get(&i2c->dev, "int", GPIOD_IN); - if (!info->int_gpiod) { + if (IS_ERR(info->int_gpiod)) { dev_err(dev, "failed to get INT GPIO\n"); - return -EINVAL; + return PTR_ERR(info->int_gpiod); } info->vbus_gpiod = devm_gpiod_get(&i2c->dev, "vbus", GPIOD_IN); - if (!info->vbus_gpiod) { + if (IS_ERR(info->vbus_gpiod)) { dev_err(dev, "failed to get VBUS GPIO\n"); - return -EINVAL; + return PTR_ERR(info->vbus_gpiod); } ret = gpiod_direction_output(info->vbus_gpiod, 0); if (ret) { |