diff options
author | Yanfei Xu <yanfei.xu@intel.com> | 2024-08-28 11:42:28 +0300 |
---|---|---|
committer | Dave Jiang <dave.jiang@intel.com> | 2024-09-09 21:33:44 +0300 |
commit | 55e268694e8b07026c88191f9b6949b6887d9ce3 (patch) | |
tree | 1efbb09471ea0660edd7d4b756120241247c2705 /drivers/cxl/port.c | |
parent | d75ccd4f2ea2aa2679e6c807d76953dcd3f9d56d (diff) | |
download | linux-55e268694e8b07026c88191f9b6949b6887d9ce3.tar.xz |
cxl/pci: Fix to record only non-zero ranges
The function cxl_dvsec_rr_decode() retrieves and records DVSEC ranges
into info->dvsec_range[], regardless of whether it is non-zero range,
and the variable info->ranges indicates the number of non-zero ranges.
However, in cxl_hdm_decode_init(), the validation for
info->dvsec_range[] occurs in a for loop that iterates based on
info->ranges. It may result in zero range to be validated but non-zero
range not be validated, in turn, the number of allowed ranges is to be
0. Address it by only record non-zero ranges.
This fix is not urgent as it requires a configuration that zeroes out
the first dvsec range while populating the second. This has not been
observed, but it is theoretically possible. If this gets picked up for
-stable, no harm done, but there is no urgency to backport.
Fixes: 560f78559006 ("cxl/pci: Retrieve CXL DVSEC memory info")
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Yanfei Xu <yanfei.xu@intel.com>
Reviewed-by: Alison Schofield <alison.schofield@intel.com>
Link: https://patch.msgid.link/20240828084231.1378789-2-yanfei.xu@intel.com
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
Diffstat (limited to 'drivers/cxl/port.c')
0 files changed, 0 insertions, 0 deletions