summaryrefslogtreecommitdiff
path: root/drivers/crypto/ccp
diff options
context:
space:
mode:
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>2023-10-20 10:55:35 +0300
committerHerbert Xu <herbert@gondor.apana.org.au>2023-10-27 13:04:25 +0300
commit304a2efe9d55875c6805f3c2957bc39ceebbc5c0 (patch)
tree77467a681fd25fd11a81d71f9e2f96f48aaf2d1a /drivers/crypto/ccp
parent580399bbc43bce232b46251e175e600407b08f5b (diff)
downloadlinux-304a2efe9d55875c6805f3c2957bc39ceebbc5c0.tar.xz
crypto: caam/jr - Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. The driver adapted here suffers from this wrong assumption. Returning -EBUSY if there are still users results in resource leaks and probably a crash. Also further down passing the error code of caam_jr_shutdown() to the caller only results in another error message and has no further consequences compared to returning zero. Still convert the driver to return no value in the remove callback. This also allows to drop caam_jr_platform_shutdown() as the only function called by it now has the same prototype. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'drivers/crypto/ccp')
0 files changed, 0 insertions, 0 deletions