summaryrefslogtreecommitdiff
path: root/drivers/cpufreq/ppc_cbe_cpufreq_pmi.c
diff options
context:
space:
mode:
authorSrivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>2014-04-28 22:54:09 +0400
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>2014-04-29 03:22:52 +0400
commit7aa0557fae5ce26dddc877869c7ad934e71f30db (patch)
treeb4bc0e272f6040a3be0fe259bfe45fb51e57515c /drivers/cpufreq/ppc_cbe_cpufreq_pmi.c
parentd1db0eea852497762cab43b905b879dfcd3b8987 (diff)
downloadlinux-7aa0557fae5ce26dddc877869c7ad934e71f30db.tar.xz
cpufreq: longhaul: Fix double invocation of cpufreq_freq_transition_begin/end
During frequency transitions, the cpufreq core takes the responsibility of invoking cpufreq_freq_transition_begin() and cpufreq_freq_transition_end() for those cpufreq drivers that define the ->target_index callback but don't set the ASYNC_NOTIFICATION flag. The longhaul cpufreq driver falls under this category, but this driver was invoking the _begin() and _end() APIs itself around frequency transitions, which led to double invocation of the _begin() API. The _begin API makes contending callers wait until the previous invocation is complete. Hence, the longhaul driver ended up waiting on itself, leading to system hangs during boot. Fix this by removing the calls to the _begin() and _end() APIs from the longhaul driver, since they rightly belong to the cpufreq core. (Note that during module_exit(), the longhaul driver sets the frequency without any help from the cpufreq core. So add explicit calls to the _begin() and _end() APIs around that frequency transition alone, to take care of that special case.) Fixes: 12478cf0c55e (cpufreq: Make sure frequency transitions are serialized) Reported-and-tested-by: Meelis Roos <mroos@linux.ee> Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'drivers/cpufreq/ppc_cbe_cpufreq_pmi.c')
0 files changed, 0 insertions, 0 deletions