diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2018-12-18 11:22:41 +0300 |
|---|---|---|
| committer | Stephen Boyd <sboyd@kernel.org> | 2019-01-09 21:35:37 +0300 |
| commit | d39eca547f3ec67140a5d765a426eb157b978a59 (patch) | |
| tree | 605cf569b96b9f0bff791f50831c61d619ec76f6 /drivers/clk/tegra | |
| parent | 48504619a65977fb2a4c7182eab637867f1e6548 (diff) | |
| download | linux-d39eca547f3ec67140a5d765a426eb157b978a59.tar.xz | |
clk: tegra: dfll: Fix a potential Oop in remove()
If tegra_dfll_unregister() fails then "soc" is an error pointer. We
should just return instead of dereferencing it.
Fixes: 1752c9ee23fb ("clk: tegra: dfll: Fix drvdata overwriting issue")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Diffstat (limited to 'drivers/clk/tegra')
| -rw-r--r-- | drivers/clk/tegra/clk-tegra124-dfll-fcpu.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/clk/tegra/clk-tegra124-dfll-fcpu.c b/drivers/clk/tegra/clk-tegra124-dfll-fcpu.c index 269d3595758b..edc31bb56674 100644 --- a/drivers/clk/tegra/clk-tegra124-dfll-fcpu.c +++ b/drivers/clk/tegra/clk-tegra124-dfll-fcpu.c @@ -133,9 +133,11 @@ static int tegra124_dfll_fcpu_remove(struct platform_device *pdev) struct tegra_dfll_soc_data *soc; soc = tegra_dfll_unregister(pdev); - if (IS_ERR(soc)) + if (IS_ERR(soc)) { dev_err(&pdev->dev, "failed to unregister DFLL: %ld\n", PTR_ERR(soc)); + return PTR_ERR(soc); + } tegra_cvb_remove_opp_table(soc->dev, soc->cvb, soc->max_freq); |