summaryrefslogtreecommitdiff
path: root/drivers/char
diff options
context:
space:
mode:
authorAlexey Brodkin <Alexey.Brodkin@synopsys.com>2012-10-03 16:27:43 +0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2012-10-24 22:29:30 +0400
commitb15d5380e471f9ce27180b14d5080abc2e2f30ec (patch)
tree5f946f9f9d0beea0e63fe304513215fd2da9ab31 /drivers/char
parent9484b009b57b6523a5c7477a899f4438942febde (diff)
downloadlinux-b15d5380e471f9ce27180b14d5080abc2e2f30ec.tar.xz
serial/8250/8250_early: Prevent rounding error in uartclk
Modify divisor to select the nearest baud rate divider rather than the lowest. It minimizes baud rate errors especially on low UART clock frequencies. For example, if uartclk is 33000000 and baud is 115200 the ratio is about 17.9 The current code selects 17 (5% error) but should select 18 (0.5% error). This 5% error in baud rate leads to garbage on receiving end, while 0.5% doesn't. The issue showed up when using the stock 8250 driver for Synopsys DW UART. This was on a FPGA with ~12MHz UART clock. When we enabled early serial, we saw garbage which was narrowed down to the rounding error. So the bug had been latent and it only showed up with such low clock rates. Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com> Acked-by: Alan Cox <alan@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/char')
0 files changed, 0 insertions, 0 deletions