diff options
| author | Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> | 2019-02-08 19:30:58 +0300 |
|---|---|---|
| committer | Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> | 2019-02-13 10:46:26 +0300 |
| commit | f5595f5baa30e009bf54d0d7653a9a0cc465be60 (patch) | |
| tree | 87fc6fd0cbd081a44bf6dd96383976a74b625aee /drivers/char/tpm/tpm_i2c_infineon.c | |
| parent | 6ea3dfe1e0732c5bd3be1e073690b06a83c03c25 (diff) | |
| download | linux-f5595f5baa30e009bf54d0d7653a9a0cc465be60.tar.xz | |
tpm: Unify the send callback behaviour
The send() callback should never return length as it does not in every
driver except tpm_crb in the success case. The reason is that the main
transmit functionality only cares about whether the transmit was
successful or not and ignores the count completely.
Suggested-by: Stefan Berger <stefanb@linux.ibm.com>
Cc: stable@vger.kernel.org
Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
Reviewed-by: Jerry Snitselaar <jsnitsel@redhat.com>
Tested-by: Alexander Steffen <Alexander.Steffen@infineon.com>
Diffstat (limited to 'drivers/char/tpm/tpm_i2c_infineon.c')
| -rw-r--r-- | drivers/char/tpm/tpm_i2c_infineon.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/char/tpm/tpm_i2c_infineon.c b/drivers/char/tpm/tpm_i2c_infineon.c index 3b490d9d90e7..3b4e9672ff6c 100644 --- a/drivers/char/tpm/tpm_i2c_infineon.c +++ b/drivers/char/tpm/tpm_i2c_infineon.c @@ -588,7 +588,7 @@ static int tpm_tis_i2c_send(struct tpm_chip *chip, u8 *buf, size_t len) /* go and do it */ iic_tpm_write(TPM_STS(tpm_dev.locality), &sts, 1); - return len; + return 0; out_err: tpm_tis_i2c_ready(chip); /* The TPM needs some time to clean up here, |