diff options
| author | Jason Gunthorpe <jgunthorpe@obsidianresearch.com> | 2013-09-15 03:36:29 +0400 |
|---|---|---|
| committer | Peter Huewe <peterhuewe@gmx.de> | 2013-10-22 21:42:26 +0400 |
| commit | 1e6e0974b5d401ab8505eca821f00fcb74d50a55 (patch) | |
| tree | 4788313b381de2ec3ab356068297ec04cae34800 /drivers/char/tpm/tpm_atmel.c | |
| parent | 37ab03414829e5cf261d7f82f0a39b505635143e (diff) | |
| download | linux-1e6e0974b5d401ab8505eca821f00fcb74d50a55.tar.xz | |
tpm atmel: Call request_region with the correct base
Commit e0dd03caf20d040a0a86 ("tpm: return chip from
tpm_register_hardware") changed the code path here so that
ateml_get_base_addr no longer directly altered the tpm_vendor_specific
structure, and instead placed the base address on the stack.
The commit missed updating the request_region call, which would have
resulted in request_region being called with 0 as the base address.
I don't know if request_region(0, ..) will fail, if so the
driver has been broken since 2006 and we should remove it
from the tree as it has no users.
Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Reviewed-by: Joel Schopp <jschopp@linux.vnet.ibm.com>
Reviewed-by: Peter Huewe <peterhuewe@gmx.de>
Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Diffstat (limited to 'drivers/char/tpm/tpm_atmel.c')
| -rw-r--r-- | drivers/char/tpm/tpm_atmel.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/char/tpm/tpm_atmel.c b/drivers/char/tpm/tpm_atmel.c index 99d6820c611d..c9a528d25d22 100644 --- a/drivers/char/tpm/tpm_atmel.c +++ b/drivers/char/tpm/tpm_atmel.c @@ -202,7 +202,7 @@ static int __init init_atmel(void) have_region = (atmel_request_region - (tpm_atmel.base, region_size, "tpm_atmel0") == NULL) ? 0 : 1; + (base, region_size, "tpm_atmel0") == NULL) ? 0 : 1; pdev = platform_device_register_simple("tpm_atmel", -1, NULL, 0); if (IS_ERR(pdev)) { |