diff options
| author | Jon Masters <jcm@jonmasters.org> | 2006-04-20 13:43:20 +0400 |
|---|---|---|
| committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-04-20 18:54:04 +0400 |
| commit | 962f831f67301265dcd2cd96408d07d95d556aed (patch) | |
| tree | 3034e297898c922479b7ad0c4d964d9fb173a50e /drivers/char/sonypi.c | |
| parent | c79cfbaccac0ef81ab3e796da1582a83dcef0ff9 (diff) | |
| download | linux-962f831f67301265dcd2cd96408d07d95d556aed.tar.xz | |
[PATCH] sound: fix hang in mpu401_uart.c
This fixes a hang in mpu401_uart.c that can occur when the mpu401 interface
is non-existent or otherwise doesn't respond to commands but we issue IO
anyway. snd_mpu401_uart_cmd now returns an error code that is passed up
the stack so that an open() will fail immediately in such cases.
Eventually discovered after wine/cxoffice would constantly cause hard
lockups on my desktop immediately after loading (emulating Windows too
well). Turned out that I'd recently moved my sound cards around and using
/dev/sequencer now talks to a sound card with a broken MPU.
This second version changes -EFAULT to -EIO and frees open resources on
error too. Test booted and seems to work ok.
Signed-off-by: Jon Masters <jcm@jonmasters.org>
Cc: Jaroslav Kysela <perex@suse.cz>
Acked-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/char/sonypi.c')
0 files changed, 0 insertions, 0 deletions