summaryrefslogtreecommitdiff
path: root/drivers/cdrom/viocd.c
diff options
context:
space:
mode:
authorStephen Rothwell <sfr@canb.auug.org.au>2008-05-21 10:24:31 +0400
committerPaul Mackerras <paulus@samba.org>2008-05-23 10:15:37 +0400
commit06a901c5621f85e07e00ac4816c7ca95620ee74a (patch)
tree0f6a0d19d889e4209a41889ed868bc8af2a581eb /drivers/cdrom/viocd.c
parentd1e8d50d5a4bc7e40b119bf513804188ce2933d0 (diff)
downloadlinux-06a901c5621f85e07e00ac4816c7ca95620ee74a.tar.xz
[POWERPC] mpic: Fix use of uninitialized variable
Compiling ppc64_defconfig with gcc 4.3 gives thes warnings: arch/powerpc/sysdev/mpic.c: In function 'mpic_irq_get_priority': arch/powerpc/sysdev/mpic.c:1351: warning: 'is_ipi' may be used uninitialized in this function arch/powerpc/sysdev/mpic.c: In function 'mpic_irq_set_priority': arch/powerpc/sysdev/mpic.c:1328: warning: 'is_ipi' may be used uninitialized in this function It turns out that in the cases where is_ipi is uninitialized, another variable (mpic) will be NULL and it is dereferenced. Protect against this by returning if mpic is NULL in mpic_irq_set_priority, and removing mpic_irq_get_priority completely as it has no in tree callers. This has the nice side effect of making the warning go away. Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au> Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> Signed-off-by: Paul Mackerras <paulus@samba.org>
Diffstat (limited to 'drivers/cdrom/viocd.c')
0 files changed, 0 insertions, 0 deletions