summaryrefslogtreecommitdiff
path: root/drivers/base
diff options
context:
space:
mode:
authorOleg Nesterov <oleg@redhat.com>2015-10-22 23:32:08 +0300
committerLinus Torvalds <torvalds@linux-foundation.org>2015-10-23 11:55:10 +0300
commit5211613978cb7353a3237e4372958c0e7514683f (patch)
tree01fae404b1b576e032245ef68ee50f0a92ea8090 /drivers/base
parent8a70dd2669200ce83255ed8c5ebef7e59f9e8707 (diff)
downloadlinux-5211613978cb7353a3237e4372958c0e7514683f.tar.xz
kmod: don't run async usermode helper as a child of kworker thread
call_usermodehelper_exec_sync() does fork() + wait() with "unignored" SIGCHLD. What we have missed is that this worker thread can have other children previously forked by call_usermodehelper_exec_work() without UMH_WAIT_PROC. If such a child exits in between it becomes a zombie because auto-reaping only works if SIGCHLD is ignored, and nobody can reap it (unless/until this worker thread exits too). Change the !UMH_WAIT_PROC case to use CLONE_PARENT. Note: this is only first step. All PF_KTHREAD tasks, even created by kernel_thread() should have ->parent == kthreadd by default. Fixes: bb304a5c6fc63d8506c ("kmod: handle UMH_WAIT_PROC from system unbound workqueue") Signed-off-by: Oleg Nesterov <oleg@redhat.com> Acked-by: Frederic Weisbecker <fweisbec@gmail.com> Cc: Rik van Riel <riel@redhat.com> Cc: Christoph Lameter <cl@linux.com> Cc: Tejun Heo <tj@kernel.org> Cc: Rusty Russell <rusty@rustcorp.com.au> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/base')
0 files changed, 0 insertions, 0 deletions