diff options
| author | Hans de Goede <hdegoede@redhat.com> | 2019-01-07 14:15:55 +0300 |
|---|---|---|
| committer | Hans de Goede <hdegoede@redhat.com> | 2019-01-09 12:35:03 +0300 |
| commit | 429188f0bc6aac7080095e07c70c77c6537cf57a (patch) | |
| tree | 79aa89d9143d64b70463cda7ada50745b9a1e6c9 /drivers/acpi/pmic/intel_pmic.h | |
| parent | 4f6016825237740257847eccd2bf446dac72182a (diff) | |
| download | linux-429188f0bc6aac7080095e07c70c77c6537cf57a.tar.xz | |
ACPI / PMIC: Add generic intel_soc_pmic_exec_mipi_pmic_seq_element handling
Most PMIC-s use only a single i2c-address, so after verifying the
i2c-address matches, we can simply pass the call to regmap_update_bits.
This commit adds support for this and hooks this up for the xpower AXP288
PMIC by setting the new pmic_i2c_address field.
This fixes the following errors on display on / off on a Jumper Ezpad
mini 3 and an Onda V80 plus tablet, both of which use the AXP288:
intel_soc_pmic_exec_mipi_pmic_seq_element: Not implemented
intel_soc_pmic_exec_mipi_pmic_seq_element: i2c-addr: 0x34 reg-addr ...
[drm:mipi_exec_pmic [i915]] *ERROR* mipi_exec_pmic failed, error: -95
Instead of these errors on both devices we now correctly turn on / off
DLDO3 (through direct register manipulation). On the Onda V80 plus this
fixes an issue with the backlight being brighter around the borders after
an off / on cycle. This should also help to save some power when the
display is off.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190107111556.4510-4-hdegoede@redhat.com
Diffstat (limited to 'drivers/acpi/pmic/intel_pmic.h')
| -rw-r--r-- | drivers/acpi/pmic/intel_pmic.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/acpi/pmic/intel_pmic.h b/drivers/acpi/pmic/intel_pmic.h index 5cd195fabca8..89379476a1df 100644 --- a/drivers/acpi/pmic/intel_pmic.h +++ b/drivers/acpi/pmic/intel_pmic.h @@ -21,6 +21,8 @@ struct intel_pmic_opregion_data { int power_table_count; struct pmic_table *thermal_table; int thermal_table_count; + /* For generic exec_mipi_pmic_seq_element handling */ + int pmic_i2c_address; }; int intel_pmic_install_opregion_handler(struct device *dev, acpi_handle handle, struct regmap *regmap, struct intel_pmic_opregion_data *d); |