diff options
| author | Rusty Russell <rusty@rustcorp.com.au> | 2013-07-15 05:51:32 +0400 |
|---|---|---|
| committer | Rusty Russell <rusty@rustcorp.com.au> | 2013-07-15 05:55:02 +0400 |
| commit | 228b82211b47b597fa75dff2ac146b40eaaddf18 (patch) | |
| tree | fc453094bf34a0159d2d335fbd9c507ba420c968 /drivers/acpi/acpi_pad.c | |
| parent | 8c6ffba0eddc8c110dbf444f51354ce42069abfc (diff) | |
| download | linux-228b82211b47b597fa75dff2ac146b40eaaddf18.tar.xz | |
s390: Replace weird use of PTR_RET.
Saves repeating "(void __force *)__uptr" but it's less clear. Using
the output of PTR_RET() to determine the error rather than just
testing IS_ERR() is odd.
For example, I *assume* __gptr_to_uptr() never returns NULL? Because
the __ret would be 0 for the old code. The new version is clearer, IMHO:
it would try to get_user() on that address.
If you hate this variant, I can just s/PTR_RET/PTR_ERR_OR_ZERO/ instead.
Cc: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Acked-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Diffstat (limited to 'drivers/acpi/acpi_pad.c')
0 files changed, 0 insertions, 0 deletions