diff options
author | Xiaoguang Wang <xiaoguang.wang@linux.alibaba.com> | 2020-12-14 18:49:41 +0300 |
---|---|---|
committer | Jens Axboe <axboe@kernel.dk> | 2020-12-23 03:14:53 +0300 |
commit | c07e6719511e77c4b289f62bfe96423eb6ea061d (patch) | |
tree | 1a6848f00dec676fba687d55aae5da8cab9af522 /block | |
parent | 9faadcc8abe4b83d0263216dc3a6321d5bbd616b (diff) | |
download | linux-c07e6719511e77c4b289f62bfe96423eb6ea061d.tar.xz |
io_uring: hold uring_lock while completing failed polled io in io_wq_submit_work()
io_iopoll_complete() does not hold completion_lock to complete polled io,
so in io_wq_submit_work(), we can not call io_req_complete() directly, to
complete polled io, otherwise there maybe concurrent access to cqring,
defer_list, etc, which is not safe. Commit dad1b1242fd5 ("io_uring: always
let io_iopoll_complete() complete polled io") has fixed this issue, but
Pavel reported that IOPOLL apart from rw can do buf reg/unreg requests(
IORING_OP_PROVIDE_BUFFERS or IORING_OP_REMOVE_BUFFERS), so the fix is not
good.
Given that io_iopoll_complete() is always called under uring_lock, so here
for polled io, we can also get uring_lock to fix this issue.
Fixes: dad1b1242fd5 ("io_uring: always let io_iopoll_complete() complete polled io")
Cc: <stable@vger.kernel.org> # 5.5+
Signed-off-by: Xiaoguang Wang <xiaoguang.wang@linux.alibaba.com>
Reviewed-by: Pavel Begunkov <asml.silence@gmail.com>
[axboe: don't deref 'req' after completing it']
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block')
0 files changed, 0 insertions, 0 deletions