summaryrefslogtreecommitdiff
path: root/block/partitions
diff options
context:
space:
mode:
authorGustavo A. R. Silva <gustavo@embeddedor.com>2018-09-04 16:20:01 +0300
committerJohannes Berg <johannes.berg@intel.com>2018-09-05 11:15:48 +0300
commit40b5a0f8c6c701dddd9b508b1d244203e89e9422 (patch)
tree75d8722bbe44f0d48c15672be048a6d4e2af3d3a /block/partitions
parent9739fe29a207ffff55361a3047e7780ebddccdb2 (diff)
downloadlinux-40b5a0f8c6c701dddd9b508b1d244203e89e9422.tar.xz
mac80211: remove unnecessary NULL check
Both old and new cannot be NULL at the same time, hence checking new when old is not NULL is unnecessary. Also, notice that new is being dereferenced before it is checked: idx = new->conf.keyidx; The above triggers a static code analysis warning. Address this by removing the NULL check on new and adding a code comment based on the following piece of code: 387 /* caller must provide at least one old/new */ 388 if (WARN_ON(!new && !old)) 389 return 0; Addresses-Coverity-ID: 1473176 ("Dereference before null check") Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Diffstat (limited to 'block/partitions')
0 files changed, 0 insertions, 0 deletions