diff options
| author | Palik, Imre <imrep@amazon.de> | 2015-06-19 15:21:51 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2015-06-23 13:34:02 +0300 |
| commit | 12b322ac85208de564ecf23aa754d796a91de21f (patch) | |
| tree | 27923ea28478e5becfc6a226beddee2b9b71cc31 /block/noop-iosched.c | |
| parent | 754bc547f0a79f7568b5b81c7fc0a8d044a6571a (diff) | |
| download | linux-12b322ac85208de564ecf23aa754d796a91de21f.tar.xz | |
xen-netback: fix a BUG() during initialization
Commit edafc132baac ("xen-netback: making the bandwidth limiter runtime settable")
introduced the capability to change the bandwidth rate limit at runtime.
But it also introduced a possible crashing bug.
If netback receives two XenbusStateConnected without getting the
hotplug-status watch firing in between, then it will try to register the
watches for the rate limiter again. But this triggers a BUG() in the watch
registration code.
The fix modifies connect() to remove the possibly existing packet-rate
watches before trying to install those watches. This behaviour is in line
with how connect() deals with the hotplug-status watch.
Signed-off-by: Imre Palik <imrep@amazon.de>
Cc: Matt Wilson <msw@amazon.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'block/noop-iosched.c')
0 files changed, 0 insertions, 0 deletions