diff options
author | Coly Li <colyli@suse.de> | 2020-04-09 17:17:21 +0300 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-06-22 10:31:06 +0300 |
commit | 7f5d77570b0cbdedb442aca1f636ed771e8210cf (patch) | |
tree | 6fd813106449fff343a4d617c26ee82e964f3854 /block/blk-iocost.c | |
parent | cd4013947eae450d93ec02f39c552ad73186a80f (diff) | |
download | linux-7f5d77570b0cbdedb442aca1f636ed771e8210cf.tar.xz |
raid5: remove gfp flags from scribble_alloc()
[ Upstream commit ba54d4d4d2844c234f1b4692bd8c9e0f833c8a54 ]
Using GFP_NOIO flag to call scribble_alloc() from resize_chunk() does
not have the expected behavior. kvmalloc_array() inside scribble_alloc()
which receives the GFP_NOIO flag will eventually call kmalloc_node() to
allocate physically continuous pages.
Now we have memalloc scope APIs in mddev_suspend()/mddev_resume() to
prevent memory reclaim I/Os during raid array suspend context, calling
to kvmalloc_array() with GFP_KERNEL flag may avoid deadlock of recursive
I/O as expected.
This patch removes the useless gfp flags from parameters list of
scribble_alloc(), and call kvmalloc_array() with GFP_KERNEL flag. The
incorrect GFP_NOIO flag does not exist anymore.
Fixes: b330e6a49dc3 ("md: convert to kvmalloc")
Suggested-by: Michal Hocko <mhocko@suse.com>
Signed-off-by: Coly Li <colyli@suse.de>
Signed-off-by: Song Liu <songliubraving@fb.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'block/blk-iocost.c')
0 files changed, 0 insertions, 0 deletions