diff options
| author | Colin Ian King <colin.king@canonical.com> | 2020-10-01 14:39:00 +0300 |
|---|---|---|
| committer | Peter Zijlstra <peterz@infradead.org> | 2020-10-03 17:30:56 +0300 |
| commit | 59d5396a4666195f89a67e118e9e627ddd6f53a1 (patch) | |
| tree | d2700e4ef9aa34ae4f4aa13217f0ada89e947dd2 /arch | |
| parent | 80a5ce116fc084e8a25d5a936617699e2931b611 (diff) | |
| download | linux-59d5396a4666195f89a67e118e9e627ddd6f53a1.tar.xz | |
x86/events/amd/iommu: Fix sizeof mismatch
An incorrect sizeof is being used, struct attribute ** is not correct,
it should be struct attribute *. Note that since ** is the same size as
* this is not causing any issues. Improve this fix by using sizeof(*attrs)
as this allows us to not even reference the type of the pointer.
Addresses-Coverity: ("Sizeof not portable (SIZEOF_MISMATCH)")
Fixes: 51686546304f ("x86/events/amd/iommu: Fix sysfs perf attribute groups")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20201001113900.58889-1-colin.king@canonical.com
Diffstat (limited to 'arch')
| -rw-r--r-- | arch/x86/events/amd/iommu.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/x86/events/amd/iommu.c b/arch/x86/events/amd/iommu.c index fb616203ce42..be50ef8572cc 100644 --- a/arch/x86/events/amd/iommu.c +++ b/arch/x86/events/amd/iommu.c @@ -379,7 +379,7 @@ static __init int _init_events_attrs(void) while (amd_iommu_v2_event_descs[i].attr.attr.name) i++; - attrs = kcalloc(i + 1, sizeof(struct attribute **), GFP_KERNEL); + attrs = kcalloc(i + 1, sizeof(*attrs), GFP_KERNEL); if (!attrs) return -ENOMEM; |