summaryrefslogtreecommitdiff
path: root/arch/x86/include/asm/microcode_amd.h
diff options
context:
space:
mode:
authorTorsten Kaiser <just.for.lkml@googlemail.com>2013-07-23 21:40:49 +0400
committerBorislav Petkov <bp@suse.de>2013-08-12 20:25:00 +0400
commit8c6b79bb1211d91fb31bcbc2a1eea8d6963d3ad9 (patch)
tree4c7798be97b8f220f242eacb2c861de658b8f88f /arch/x86/include/asm/microcode_amd.h
parentd4e4ab86bcba5a72779c43dc1459f71fea3d89c8 (diff)
downloadlinux-8c6b79bb1211d91fb31bcbc2a1eea8d6963d3ad9.tar.xz
x86, microcode, AMD: Make cpu_has_amd_erratum() use the correct struct cpuinfo_x86
cpu_has_amd_erratum() is buggy, because it uses the per-cpu cpu_info before it is filled by smp_store_boot_cpu_info() / smp_store_cpu_info(). If early microcode loading is enabled its collect_cpu_info_amd_early() will fill ->x86 and so the fallback to boot_cpu_data is not used. But ->x86_vendor was not filled and is still X86_VENDOR_INTEL resulting in no errata fixes getting applied and my system hangs on boot. Using cpu_info in cpu_has_amd_erratum() is wrong anyway: its only caller init_amd() will have a struct cpuinfo_x86 as parameter and the set_cpu_bug() that is controlled by cpu_has_amd_erratum() also only uses that struct. So pass the struct cpuinfo_x86 from init_amd() to cpu_has_amd_erratum() and the broken fallback can be dropped. [ Boris: Drop WARN_ON() since we're called only from init_amd() ] Signed-off-by: Torsten Kaiser <just.for.lkml@googlemail.com> Signed-off-by: Borislav Petkov <bp@suse.de>
Diffstat (limited to 'arch/x86/include/asm/microcode_amd.h')
0 files changed, 0 insertions, 0 deletions