diff options
| author | Sam Ravnborg <sam@ravnborg.org> | 2014-04-21 23:39:35 +0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2014-04-29 09:12:26 +0400 |
| commit | a3ee8faa1b1bd02aaffe6dd0fd13d665234530f3 (patch) | |
| tree | c683472a747729de2158a07d62faafe830e5d191 /arch/sparc/include/asm/auxio_64.h | |
| parent | 3731e199109f59c8c134df639f1012a451e6d843 (diff) | |
| download | linux-a3ee8faa1b1bd02aaffe6dd0fd13d665234530f3.tar.xz | |
sparc32: fix sparse warnings in auxio_32.c
Fix following warnings:
auxio_32.c:23:14: warning: symbol 'auxio_register' was not declared. Should it be static?
auxio_32.c:26:13: warning: symbol 'auxio_probe' was not declared. Should it be static?
auxio_32.c:108:13: warning: symbol 'auxio_power_probe' was not declared. Should it be static?
Add proper decalarations for the above.
The leaves one sparse warning:
auxio_32.c:130:33: warning: cast removes address space of expression
This is here:
auxio_power_register = (unsigned char *) of_ioremap()
This is __iomem that is removed from return value of of_ioremap()
The pointer is later used without any helpers in process_32.c:
*auxio_power_register |= AUXIO_POWER_OFF;
It would be simple to introduce a few sbus() helpers.
But as I was not sure this was correct the warning are left as-is.
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'arch/sparc/include/asm/auxio_64.h')
| -rw-r--r-- | arch/sparc/include/asm/auxio_64.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/arch/sparc/include/asm/auxio_64.h b/arch/sparc/include/asm/auxio_64.h index f61cd1e3e395..7af9766a1c35 100644 --- a/arch/sparc/include/asm/auxio_64.h +++ b/arch/sparc/include/asm/auxio_64.h @@ -75,8 +75,6 @@ #ifndef __ASSEMBLY__ -extern void __iomem *auxio_register; - #define AUXIO_LTE_ON 1 #define AUXIO_LTE_OFF 0 |