diff options
author | Julia Lawall <Julia.Lawall@lip6.fr> | 2015-10-10 15:30:52 +0300 |
---|---|---|
committer | Simon Horman <horms+renesas@verge.net.au> | 2015-10-12 03:15:29 +0300 |
commit | 1fd377b3fc1e071702e27b2f828e3abd8b31c74d (patch) | |
tree | cea9957d753672e2d224c81a29976a9c47cece16 /arch/arm/mach-shmobile/pm-rmobile.c | |
parent | e5cf79d9957d958c0c5fd1cbc4eda6c48c563888 (diff) | |
download | linux-1fd377b3fc1e071702e27b2f828e3abd8b31c74d.tar.xz |
ARM: shmobile: R-Mobile: add missing of_node_put
for_each_child_of_node performs an of_node_get on each iteration, so
a break out of the loop requires an of_node_put.
The semantic patch that fixes this problem is as follows
(http://coccinelle.lip6.fr):
// <smpl>
@@
expression root,e;
local idexpression child;
@@
for_each_child_of_node(root, child) {
... when != of_node_put(child)
when != e = child
(
return child;
|
+ of_node_put(child);
? return ...;
)
...
}
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
Diffstat (limited to 'arch/arm/mach-shmobile/pm-rmobile.c')
-rw-r--r-- | arch/arm/mach-shmobile/pm-rmobile.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/arch/arm/mach-shmobile/pm-rmobile.c b/arch/arm/mach-shmobile/pm-rmobile.c index a5b96b990aea..424155b0cfe9 100644 --- a/arch/arm/mach-shmobile/pm-rmobile.c +++ b/arch/arm/mach-shmobile/pm-rmobile.c @@ -342,8 +342,10 @@ static int __init rmobile_add_pm_domains(void __iomem *base, } pd = kzalloc(sizeof(*pd), GFP_KERNEL); - if (!pd) + if (!pd) { + of_node_put(np); return -ENOMEM; + } pd->genpd.name = np->name; pd->base = base; |