diff options
author | Benjamin Block <bblock@linux.ibm.com> | 2019-07-03 00:02:01 +0300 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-06-03 09:18:13 +0300 |
commit | ed818a3dd28ea58bce69951e3cf85c43fe9170c6 (patch) | |
tree | f233cbc620692cbc795f0eb4ad62662514592587 /Makefile | |
parent | f38022c80e463c195d56baec85e075e0f15a0d3e (diff) | |
download | linux-ed818a3dd28ea58bce69951e3cf85c43fe9170c6.tar.xz |
scsi: zfcp: fix request object use-after-free in send path causing wrong traces
[ Upstream commit 106d45f350c7cac876844dc685845cba4ffdb70b ]
When tracing instances where we open and close WKA ports, we also pass the
request-ID of the respective FSF command.
But after successfully sending the FSF command we must not use the
request-object anymore, as this might result in an use-after-free (see
"zfcp: fix request object use-after-free in send path causing seqno
errors" ).
To fix this add a new variable that caches the request-ID before sending
the request. This won't change during the hand-off to the FCP channel,
and so it's safe to trace this cached request-ID later, instead of using
the request object.
Signed-off-by: Benjamin Block <bblock@linux.ibm.com>
Fixes: d27a7cb91960 ("zfcp: trace on request for open and close of WKA port")
Cc: <stable@vger.kernel.org> #2.6.38+
Reviewed-by: Steffen Maier <maier@linux.ibm.com>
Reviewed-by: Jens Remus <jremus@linux.ibm.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'Makefile')
0 files changed, 0 insertions, 0 deletions