summaryrefslogtreecommitdiff
path: root/Kconfig
diff options
context:
space:
mode:
authorPeter Hurley <peter@hurleysoftware.com>2014-10-16 21:46:38 +0400
committerLuis Henriques <luis.henriques@canonical.com>2014-11-14 18:20:00 +0300
commit2f590344973f74446798a11a065e2e9f774a236f (patch)
tree520899a34a943c6eae3da0b644d73df7d9142e5b /Kconfig
parent8a68df4e1ce17cf20d0d01227b08a38ac6ac4fcc (diff)
downloadlinux-2f590344973f74446798a11a065e2e9f774a236f.tar.xz
serial: Fix divide-by-zero fault in uart_get_divisor()
commit 547039ec502076e60034eeb79611df3433a99b7d upstream. uart_get_baud_rate() will return baud == 0 if the max rate is set to the "magic" 38400 rate and the SPD_* flags are also specified. On the first iteration, if the current baud rate is higher than the max, the baud rate is clamped at the max (which in the degenerate case is 38400). On the second iteration, the now-"magic" 38400 baud rate selects the possibly higher alternate baud rate indicated by the SPD_* flag. Since only two loop iterations are performed, the loop is exited, a kernel WARNING is generated and a baud rate of 0 is returned. Reproducible with: setserial /dev/ttyS0 spd_hi base_baud 38400 Only perform the "magic" 38400 -> SPD_* baud transform on the first loop iteration, which prevents the degenerate case from recognizing the clamped baud rate as the "magic" 38400 value. Reported-by: Robert Święcki <robert@swiecki.net> Signed-off-by: Peter Hurley <peter@hurleysoftware.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
Diffstat (limited to 'Kconfig')
0 files changed, 0 insertions, 0 deletions