diff options
author | Ben Skeggs <bskeggs@redhat.com> | 2013-09-17 08:21:15 +0400 |
---|---|---|
committer | Dave Airlie <airlied@redhat.com> | 2013-09-19 05:48:30 +0400 |
commit | 182b17c8dc4e83aab000ce86587b6810e515da87 (patch) | |
tree | 64962eec5002e424d812cd9564e549daf801c03a /Kbuild | |
parent | 4f7d1bc973ec71dfeeb951765cafe1ff3a63243e (diff) | |
download | linux-182b17c8dc4e83aab000ce86587b6810e515da87.tar.xz |
drm/ttm: fix the tt_populated check in ttm_tt_destroy()
After a vmalloc failure in ttm_dma_tt_alloc_page_directory(),
ttm_dma_tt_init() will call ttm_tt_destroy() to cleanup, and end up
inside the driver's unpopulate() hook when populate() has never yet
been called.
On nouveau, the first issue to be hit because of this is that
dma_address[] may be a NULL pointer. After working around this,
ttm_pool_unpopulate() may potentially hit the same issue with
the pages[] array.
It seems to make more sense to avoid calling unpopulate on already
unpopulated TTMs than to add checks to all the implementations.
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com>
Cc: stable@vger.kernel.org
Cc: Jerome Glisse <jglisse@redhat.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
Diffstat (limited to 'Kbuild')
0 files changed, 0 insertions, 0 deletions