diff options
| author | Jason Wang <jasowang@redhat.com> | 2022-06-20 08:11:14 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-07-07 18:52:18 +0300 |
| commit | 653bdcd833b7505987bbda852144c8b6a4b2ab3a (patch) | |
| tree | 7fd8e597feef7f30bd1160c0daf78b89b6b338e7 /Documentation | |
| parent | 208ff7967534329a8a2e1bba1e20e0e29b6d90c6 (diff) | |
| download | linux-653bdcd833b7505987bbda852144c8b6a4b2ab3a.tar.xz | |
caif_virtio: fix race between virtio_device_ready() and ndo_open()
commit 11a37eb66812ce6a06b79223ad530eb0e1d7294d upstream.
We currently depend on probe() calling virtio_device_ready() -
which happens after netdev
registration. Since ndo_open() can be called immediately
after register_netdev, this means there exists a race between
ndo_open() and virtio_device_ready(): the driver may start to use the
device (e.g. TX) before DRIVER_OK which violates the spec.
Fix this by switching to use register_netdevice() and protect the
virtio_device_ready() with rtnl_lock() to make sure ndo_open() can
only be called after virtio_device_ready().
Fixes: 0d2e1a2926b18 ("caif_virtio: Introduce caif over virtio")
Signed-off-by: Jason Wang <jasowang@redhat.com>
Message-Id: <20220620051115.3142-3-jasowang@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'Documentation')
0 files changed, 0 insertions, 0 deletions