diff options
author | Arnd Bergmann <arnd@arndb.de> | 2015-02-03 18:55:54 +0300 |
---|---|---|
committer | Ulf Hansson <ulf.hansson@linaro.org> | 2015-02-04 11:42:29 +0300 |
commit | 3981c516664d81a3e83c1923fa1ab3988c529402 (patch) | |
tree | c7c43a53c07d85fe91eabe9dc508b191e256df8b /Documentation | |
parent | 4febb7e20aa619e2b2845519dad247e4038dc383 (diff) | |
download | linux-3981c516664d81a3e83c1923fa1ab3988c529402.tar.xz |
mmc: moxart: fix probe logic
Jonas Jensen wanted to submit a patch for these, but apparently
forgot about it. I stumbled over this symptom first:
drivers/built-in.o: In function `moxart_probe':
:(.text+0x2af128): undefined reference to `of_dma_request_slave_channel'
This is because of_dma_request_slave_channel is an internal helper
and not exported to loadable module. I'm changing the driver to
use dma_request_slave_channel_reason() instead.
Further problems from inspection:
* The remove function must not call kfree on the host pointer,
because it is allocated together with the mmc_host.
* The clock is never released
* The dma_cap_mask_t is completely unused and can be removed
* deferred probing does not work if the dma driver is loaded
after the mmc driver.
This patch should fix all of the above.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Jonas Jensen <jonas.jensen@gmail.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Diffstat (limited to 'Documentation')
0 files changed, 0 insertions, 0 deletions